Skip to content

[file_packager] Remove redundant isNode check #24884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

[file_packager] Remove redundant isNode check #24884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions tools/file_packager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,15 +805,9 @@ def generate_js(data_target, data_files, metadata):
var DB_VERSION = 1;
var METADATA_STORE_NAME = 'METADATA';
var PACKAGE_STORE_NAME = 'PACKAGES';
function openDatabase(callback, errback) {'''
if options.support_node:
code += '''
if (isNode) {
return errback();
}'''
code += '''
function openDatabase(callback, errback) {
if (typeof indexedDB == 'undefined') {
throw 'using IndexedDB to cache data can only be done on a web page or in a web worker';
return errback('using IndexedDB to cache data can only be done on a web page or in a web worker');
Copy link
Collaborator Author

@sbc100 sbc100 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have test coverage for this since without this part of the change the other.test_file_packager_separate_metadata fails under node

}
try {
var openRequest = indexedDB.open(DB_NAME, DB_VERSION);
Expand Down