Skip to content

[file_packager.py] Convert fetchRemotePackage to promise #24892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lkwinta
Copy link

@lkwinta lkwinta commented Aug 8, 2025

Followup to: #24883

@lkwinta
Copy link
Author

lkwinta commented Aug 8, 2025

@sbc100 @kripken please take a look here

@lkwinta lkwinta changed the title [file_packager.py] Convert fetchRemotePackage to async [file_packager.py] Convert fetchRemotePackage to promise Aug 8, 2025
@lkwinta lkwinta closed this Aug 8, 2025
@lkwinta lkwinta deleted the file_packager_async_part4 branch August 8, 2025 21:15
@sbc100
Copy link
Collaborator

sbc100 commented Aug 8, 2025

Oops, this looks like it duplicates part 4 or my PR chain: #24893

@lkwinta
Copy link
Author

lkwinta commented Aug 8, 2025

Oops, this looks like it duplicates part 4 or my PR chain: #24893

Yup I have just realized, not a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants