[file_packager] Remove unused errback fetchRemovePackage. NFC
#24904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't errback used on line 958 (for node)? |
This argument has basically used since 3839dd4. Even when this function was first add in 74f3242 the errback callback was only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers. The exception here was that when node support was added in emscripten-core#11785 it, I believe incorrectly used errback to handle file read errors (doesn't match the web version that does *not* handle fetch error using errback). This is small cleanup in advance of emscripten-core#24893.
sbc100
force-pushed
the
file_packager_fix_fetchRemotePackage
branch
from
67af9a8 to
ba82237
Compare
|
Oops, you are correct, however I believe that usage was wrong so I updated it. |
|
I also updated the PR description. |
kripken
approved these changes
Aug 11, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 11, 2025
The last usage was removed in emscripten-core#24904 but I forgot to remove the function itself.
sbc100
added a commit
that referenced
this pull request
Aug 11, 2025
The last usage was removed in #24904 but I forgot to remove the function itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument has been used since 3839dd4.
Even when this function was first added in 74f3242,
errbackwas only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers.The exception here was that when node support was added in #11785 it, I believe incorrectly used errback to handle file read errors (doesn't match the web version that does not handle fetch error using errback).
I'm not claiming this is correct/best behaviour, this is simply an NFC to cleanup an already-unused argument.
This is small cleanup in advance of #24893.