Skip to content

Remove Node.js self.run_js() test in browser suite. #25473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
+0 −7
Merged

Remove Node.js self.run_js() test in browser suite. #25473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf55b9
Remove Node.js self.run_js() test in browser suite. The browser suite…
juj Oct 2, 2025
f404cae
Remove EMTEST_SKIP_NODE_CANARY
juj Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,6 @@ jobs:
executor: focal
environment:
EMTEST_LACKS_WEBGPU: "1"
EMTEST_SKIP_NODE_CANARY: "1"
steps:
- run-tests-chrome:
title: "browser64_4gb"
Expand Down
6 changes: 0 additions & 6 deletions test/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,12 +1605,6 @@ def test_hello_world_worker(self, file_data):
self.assertExists('worker.js')
self.run_browser('main.html', '/report_result?hello from worker, and :' + ('data for w' if file_data else '') + ':')

# code should run standalone too
# To great memories >4gb we need the canary version of node
if self.is_4gb():
self.require_node_canary()
self.assertContained('you should not see this text when in a worker!', self.run_js('worker.js'))

@no_wasmfs('https://github.com/emscripten-core/emscripten/issues/19608')
def test_mmap_lazyfile(self):
create_file('lazydata.dat', 'hello world')
Expand Down