Skip to content

Bump min Firefox version to 68 ESR #25493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 7, 2025
+9 −20
Merged

Bump min Firefox version to 68 ESR #25493

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ea6b92
Bump min Firefox version to 68 ESR
juj Oct 4, 2025
a395467
Update ChangeLog
juj Oct 4, 2025
53d52a9
Update test
juj Oct 4, 2025
4091b66
Remove documentation for Firefox < 68
juj Oct 4, 2025
db0900f
Revise ChangeLog
juj Oct 4, 2025
f97d539
Merge remote-tracking branch 'origin/main' into min_firefox_68
juj Oct 7, 2025
37a3453
Update ChangeLog
juj Oct 7, 2025
bf05686
Remove old Firefox path
juj Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ See docs/process.md for more on how version tagging works.
- Node: v10.19.0 -> v12.22.9
- Chrome: v70 -> v74
- Firefox: v55 -> v65
- Minimum Firefox version was further bumped up to Firefox 68 ESR - older
Firefox versions are not able to run the parallel browser harness (#25493)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe delete the line above (and use the same "Firefox: X -> Y" format as the above bumps)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting Firefox: v55 -> v65 would lose the info on which version of Firefox added the globalThis polyfill. I think having a mention of that in the ChangeLog is valuable, since it validates that Firefox is known to unconditionally also support it.

- The Embind `val` functions `call`, `operator()`, and `new_` now support
passing `pointer`s by using the `allow_raw_pointers()` argument. This feature
is only enabled with C++17 and newer. Older versions will allow pointers by
Expand Down
2 changes: 1 addition & 1 deletion site/source/docs/tools_reference/settings_reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2871,7 +2871,7 @@ are desired to work. Pass -sMIN_FIREFOX_VERSION=majorVersion to drop support
for Firefox versions older than < majorVersion.
Firefox 79 was released on 2020-07-28.
MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
Minimum supported value is 65 which was released on 2019-01-29 (see
Minimum supported value is 68 which was released on 2019-07-09 (see
feature_matrix.py)

Default value: 79
Expand Down
2 changes: 1 addition & 1 deletion src/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,7 +1880,7 @@ var AUTO_NATIVE_LIBRARIES = true;
// for Firefox versions older than < majorVersion.
// Firefox 79 was released on 2020-07-28.
// MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
// Minimum supported value is 65 which was released on 2019-01-29 (see
// Minimum supported value is 68 which was released on 2019-07-09 (see
// feature_matrix.py)
// [link]
var MIN_FIREFOX_VERSION = 79;
Expand Down
3 changes: 0 additions & 3 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ def configure(data_dir):
"""Chrome has no special configuration step."""


# N.b. The earliest Firefox version that can run multithreaded browser harness
# is Firefox 67. If you need to test earlier Firefox versions, use EMTEST_CORES=1
# environment variable to revert to the single-threaded browser harness.
class FirefoxConfig:
data_dir_flag = '-profile '
default_flags = ('-new-instance',)
Expand Down
6 changes: 3 additions & 3 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10530,7 +10530,7 @@ def compile(flags):
compile(['-sMIN_SAFARI_VERSION=160000', '-mno-sign-ext'])
verify_features_sec_linked('sign-ext', False)
# Flag enabling overrides explicit browser version
compile(['-sMIN_FIREFOX_VERSION=65', '-msign-ext'])
compile(['-sMIN_FIREFOX_VERSION=68', '-msign-ext'])
verify_features_sec_linked('sign-ext', True)
# Flag disabling overrides explicit version for bulk memory
compile(['-sMIN_SAFARI_VERSION=150000', '-mno-bulk-memory'])
Expand Down Expand Up @@ -14391,8 +14391,8 @@ def test_min_browser_version(self):
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-sWASM_BIGINT', '-sMIN_SAFARI_VERSION=130000'])
self.assertContained('emcc: error: MIN_SAFARI_VERSION=130000 is not compatible with WASM_BIGINT (MIN_SAFARI_VERSION=150000 or above required)', err)

err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=65'])
self.assertContained('emcc: error: MIN_FIREFOX_VERSION=65 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)
err = self.expect_fail([EMCC, test_file('hello_world.c'), '-Wno-transpile', '-Werror', '-pthread', '-sMIN_FIREFOX_VERSION=68'])
self.assertContained('emcc: error: MIN_FIREFOX_VERSION=68 is not compatible with pthreads (MIN_FIREFOX_VERSION=79 or above required)', err)

# Test that using two different ways to disable a target environment at the same time will not produce a warning.
def test_double_disable_environment(self):
Expand Down
2 changes: 1 addition & 1 deletion tools/feature_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# N.b. when modifying these values, update comments in src/settings.js on
# MIN_x_VERSION fields to match accordingly.
OLDEST_SUPPORTED_CHROME = 74 # Released on 2019-04-23
OLDEST_SUPPORTED_FIREFOX = 65 # Released on 2019-01-29
OLDEST_SUPPORTED_FIREFOX = 68 # Released on 2019-07-09
OLDEST_SUPPORTED_SAFARI = 120200 # Released on 2019-03-25
# 12.22.09 is the oldest version of node that we do any testing with.
# Keep this in sync with the test-node-compat in .circleci/config.yml.
Expand Down