fix: added missing options to EmscriptenAudioWorkletNodeCreateOptions closes #23982 #25497
Conversation
system/include/emscripten/webaudio.h
Outdated
| // Extended options from AudioWorkletNode | ||
| int channelCount; | ||
| int channelCountMode; | ||
| int channelInterpretation; |
There was a problem hiding this comment.
channelCountMode and channelInterpretation are strings, so an integer will not work.
Create an enum for those, and in the JS code, index the enum into an array of strings.
See e.g. https://github.com/juj/wasm_webgpu/blob/3ed529956d1ee3f14f64c07769385e1929908f68/lib/lib_webgpu.js#L615 and https://github.com/juj/wasm_webgpu/blob/3ed529956d1ee3f14f64c07769385e1929908f68/lib/lib_webgpu.js#L729 in another repo for examples.
system/include/emscripten/webaudio.h
Outdated
| int numberOfOutputs; | ||
| // For each output, specifies the number of audio channels (1=mono/2=stereo/etc.) for that output. Default=an array of ones for each output channel. | ||
| int *outputChannelCounts; | ||
| // Extended options from AudioWorkletNode |
There was a problem hiding this comment.
This comment documents the history of evolution of the codebase (i.e. "before this PR, we had a 'basic' set, after this PR, we now have 'extended' set"), but in the Web Audio specification, there is no distinction between basic and extended options - there are just options.
So instead of documenting history of evolution, maybe add short comments that describe the new parameters?
Problem Description
The EmscriptenAudioWorkletNodeCreateOptions struct currently only exposes options specific to AudioWorkletNode itself (numberOfInputs, numberOfOutputs, outputChannelCounts), but AudioWorkletNode inherits from AudioNode which has additional properties:
Fix
system/include/emscripten/webaudio.h.src/lib/libwebaudio.jsto pass these options to theAudioWorkletNodeconstructor.Closes #23982