Enable support for running the test harness in Safari. #25499
Conversation
juj
changed the title
test/common.py
Outdated
| # by the delta before->after. | ||
| cls.browser_procs = list(set(procs_after).difference(set(procs_before))) | ||
| if len(cls.browser_procs) == 0: | ||
| logger.warning('Could not detect the launched browser subprocesses. The test harness may not be able to close browser windows if a test hangs, and at harness exit.') |
There was a problem hiding this comment.
Can this be an error instead?
There was a problem hiding this comment.
I can make it an error, but it is only so when running with EMTEST_BROWSER_AUTO_CONFIG enabled. (I think btw disabling EMTEST_BROWSER_AUTO_CONFIG might currently be broken and atm not possible)
If user adds a custom browser string, and EMTEST_BROWSER_AUTO_CONFIG is not enabled, then the browser might run in a tab on an existing browser, in which case this detection will not work.
test/common.py
Outdated
| # --fresh: do not restore old tabs (e.g. if user had old navigated windows open) | ||
| # --background: Open the new Safari window behind the current Terminal window, to make following the test run more pleasing (this is for convenience only) | ||
| # -a <exe_name>: The path to the executable to open, in this case Safari | ||
| browser_args = ['open', '--new', '--fresh', '--background', '-a'] + browser_args |
There was a problem hiding this comment.
Shouldn't these args go in SafariConfig?
There was a problem hiding this comment.
Or maybe these should be used also for Chrome and FF on macOS? i.e. is open the way we should be launching all browsers on macOS?
There was a problem hiding this comment.
It'll need a new construct in the configs, there is no current way to model a prefix of args in the existing set of config fields. I can do that in a moment.
Using open is not needed for Firefox at least. Not sure about Chrome, but I presume not.
test/common.py
Outdated
| else: | ||
| exit_with_error(f'EMTEST_BROWSER_AUTO_CONFIG only currently works with firefox or chrome. EMTEST_BROWSER was "{EMTEST_BROWSER}"') | ||
| if not config: | ||
| exit_with_error(f'EMTEST_BROWSER_AUTO_CONFIG only currently works with firefox, chrome and safari. EMTEST_BROWSER was "{EMTEST_BROWSER}"') |
There was a problem hiding this comment.
This error seems like its unreachable since its inside the if EMTEST_BROWSER_AUTO_CONFIG and config block?
Add support for running the
browserharness withEMTEST_BROWSER=/Applications/Safari.App/Contents/MacOS/Safarion a macOS system.This fixes both the singlethreaded and multithreaded harness runs.