Unify handling of console color output. NFC #25505
Merged
+72
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be cool to land #25495 first.. now this is going again into the "refactor-everything-first-to-create-merge-conflicts" territory. |
juj
approved these changes
Oct 6, 2025
I don't have a windows machine myself but we do run Whether the platform actually renders those codes correctly we do not (cannot reasonably really) test. |
sbc100
force-pushed
the
ansi_color_followup
branch
from
4e40cae to
6811349
Compare
sbc100
changed the title
diagnostics.diag function. NFC
sbc100
changed the title
|
Happy to see #25495 land first. I increased the scope of this change to unify the color handling between the logger and diagnostics code. |
sbc100
force-pushed
the
ansi_color_followup
branch
2 times, most recently
from
8f11b47 to
ecf9b49
Compare
sbc100
force-pushed
the
ansi_color_followup
branch
from
ecf9b49 to
4f6e36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #25502.