-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[SPLIT_MODULE] Make getWasmImports return Proxy #25559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+45
−30
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e51feda
[SPLIT_MODULE] Make getWasmImports return Proxy (NFC)
aheejin 470fcfb
Automatic rebaseline of codesize expectations. NFC
aheejin 6a30a50
Address a comment
aheejin 3c5e7ad
namespace -> env
aheejin 3ddcbd1
Rename `prop` -> `base`
aheejin b2a22d4
[SPLIT_MODULE] Support multi-split loading
aheejin e918916
wasmImportsProxyHandler -> splitImportsProxyHandler
aheejin 6cb0c42
env -> moduleName
aheejin 4f2f3b3
Wrap dbg messages within RUNTIME_DEBUG
aheejin 5f2bc5f
Merge branch 'main' into nested_proxies
aheejin 68c3308
Revert "[SPLIT_MODULE] Support multi-split loading"
aheejin eaea168
Rename handlers
aheejin 147482f
Automatic rebaseline of codesize expectations. NFC
aheejin 3919476
Fix errors from previous revert ;(
aheejin 67e5380
Anonymize the inner handler
aheejin 13f034d
Remove a newline added by mistake
aheejin d0a19db
Automatic rebaseline of codesize expectations. NFC
aheejin ce9f8c8
Merge branch 'main' into nested_proxies
aheejin 6d395fb
Merge branch 'main' into nested_proxies
aheejin 6bb859f
Automatic rebaseline of codesize expectations. NFC
aheejin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
{ | ||
"hello_world.js": 56566, | ||
"hello_world.js.gz": 17601, | ||
"hello_world.js": 56592, | ||
"hello_world.js.gz": 17608, | ||
"hello_world.wasm": 15119, | ||
"hello_world.wasm.gz": 7444, | ||
"no_asserts.js": 26608, | ||
"no_asserts.js.gz": 8874, | ||
"no_asserts.js": 26634, | ||
"no_asserts.js.gz": 8883, | ||
"no_asserts.wasm": 12219, | ||
"no_asserts.wasm.gz": 6005, | ||
"strict.js": 54581, | ||
"strict.js.gz": 16947, | ||
"strict.js": 54607, | ||
"strict.js.gz": 16955, | ||
"strict.wasm": 15119, | ||
"strict.wasm.gz": 7442, | ||
"total": 180212, | ||
"total_gz": 64313 | ||
"total": 180290, | ||
"total_gz": 64337 | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(As an aside I wonder if this line should be an assert).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure... Can't this be triggered by user errors? If so an
Error
might be fine?