-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update the download.rst #25564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update the download.rst #25564
Conversation
Update the download and install instructions with Windows and Linux/Mac specific commands.
|
||
==================== | ||
Download and install | ||
Download & Install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change rather needless. Why change it?
If you do change it can you change the length of the ====
lines above and below?
emcmdprompt.bat | ||
# To use the compilation commands remember to navigate one folder up | ||
cd.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You con't need to be in any particlar directory. emcc
and other commands are now in the PATH and should work from anywhere.
cd emsdk | ||
# Run the emcmdprompt.bat file | ||
emcmdprompt.bat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just make this a single command \path\to\emsdk\emsdk_env.bat
(emsdk_env.bat
is what you use if you are already in a command window. emcmdprompt.bat
opens a new terminal windows with the environment already setup)
GitHub and set them as :term:`active <Active Tool/SDK>`: | ||
Getting the tools | ||
^^^^^^^^^^^^ | ||
To get the latest tools from GitHub and set them as :term:`active <Active Tool/SDK>` run the following :ref:`emsdk <emsdk>` commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the from GitHub
(they are actually common from google storage, not github).
# To use the compilation commands remember to navigate one folder up | ||
cd.. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm not sure we need this new windows-specific tip do we? Isn't it covered by the exiting tip below?
Update the download and install instructions with Windows and Linux/Mac specific commands.