Fix tools/install.py script to use Emsdk Node.js and NPM #25575
Conversation
tools/install.py
Outdated
|
|
||
|
|
||
| def get_npm(): | ||
| node = os.getenv('EMSDK_NODE') |
There was a problem hiding this comment.
Can we use shared.NODE_JS instead of EMSDK_NODE here? I'd rather not use these emsdk-specific things here if we can avoid it.
shared.NODE_JS is guaranteed to exist.
Maybe install.py isn't setup to import shared.py yet?
There was a problem hiding this comment.
Hmm.. I guess bootstrap.py has the same issue? Is this script also not working your CI machine?
There was a problem hiding this comment.
Updated to use config.NODE_JS
There was a problem hiding this comment.
bootstrap.py does work. It is only the test other.test_install that is failing.
There was a problem hiding this comment.
That seems odd because bootstrap.py also runs npm from the PATH.
What does the failure look like in this case? |
|
The failure looks like 
|
|
Hmm, the changes are resulting in these errors: https://github.com/emscripten-core/emscripten/actions/runs/18601976754/job/53042367932 I am a bit stumped as to what could cause this.. it is as if .emscripten no longer exists, but the changes here shouldn't affect that? |
|
The version that relied on |
|
I think the i.e we are assuming the install.py is completely standalone... but it seems like maybe it cannot actually be standalone. |
|
Could you maybe update the |
juj
force-pushed
the
fix_tools_install_script
branch
from
79c7557 to
29a72c8
Compare
|
Oh right, it is the mere act of attempting to import shared that requires .emscripten config to be present. Updated to change the test instead. |
2 participants
Fix tools/install.py script to use Emsdk Node.js and NPM. Fixes other.test_install on macOS if system macOS Node.js version is out of date.