[parallel_testsuite.py] Simplify allowed_failures_counter #25767
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 10, 2025
kripken
reviewed
Nov 10, 2025
sbc100
force-pushed
the
allowed_failures_counter
branch
from
178f336 to
ea5c3c5
Compare
We do all the modification of allowed_failures_counter on the main thread without the need for a lock. I believe this was not possible prior emscripten-core#25751.
sbc100
force-pushed
the
allowed_failures_counter
branch
from
ea5c3c5 to
6e4fefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do all the modification of allowed_failures_counter on the main thread without the need for a lock.
I believe this was not possible prior #25751.