Skip to content

Disable assertions in tsgen #25780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable assertions in tsgen #25780

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
225d3e7
Disable assertions in tsgen
stephenduong1004 Nov 11, 2025
ff9cc0f
Move settings.ASSERTIONS = 0 up to be with other settings modifications
stephenduong1004 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2056,10 +2056,10 @@ def run_embind_gen(options, wasm_target, js_syms, extra_settings):
settings.MEMORY64 = 2
# Source maps haven't been generated yet and aren't needed to run embind_gen.
settings.LOAD_SOURCE_MAP = 0
settings.ASSERTIONS = 0
Copy link
Collaborator

@sbc100 sbc100 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here as to why this is needed?

outfile_js = in_temp('tsgen.js')
# The Wasm outfile may be modified by emscripten.emscript, so use a temporary file.
outfile_wasm = in_temp('tsgen.wasm')
settings.ASSERTIONS = 0
emscripten.emscript(wasm_target, outfile_wasm, outfile_js, js_syms, finalize=False)
# Build the flags needed by Node.js to properly run the output file.
node_args = []
Expand Down