Skip to content

Fix browser test runner on macOS Safari. #25799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+1 −1
Merged

Fix browser test runner on macOS Safari. #25799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/browser_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def get_safari_version():
if not is_safari():
return UNSUPPORTED
plist_path = os.path.join(EMTEST_BROWSER.strip(), 'Contents', 'version.plist')
version_str = plistlib.load(read_binary(plist_path)).get('CFBundleShortVersionString')
version_str = plistlib.load(open(plist_path, 'rb')).get('CFBundleShortVersionString')
Copy link
Collaborator

@sbc100 sbc100 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah can we change this to loads(read_binary..) maybe ?

# Split into parts (major.minor.patch)
parts = (version_str.split('.') + ['0', '0', '0'])[:3]
# Convert each part into integers, discarding any trailing string, e.g. '13a' -> 13.
Expand Down