Skip to content

[contrib.lua] Upgraded lua to new version 5.5.0 #26033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 3 commits into from
Jan 8, 2026
+4 −5
Merged

[contrib.lua] Upgraded lua to new version 5.5.0 #26033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de24d1
Upgraded lua to new version
ypujante Jan 2, 2026
335694f
Updated ChangeLog
ypujante Jan 2, 2026
d0420eb
Merge branch 'main' into lua-5.5
ypujante Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ See docs/process.md for more on how version tagging works.
detection stages. This means the initial cmake run will be slower, but will
result in more accurate information. If cmake is running too slow for you,
you can revert to the previous behaviour with `-DEMSCRIPTEN_FORCE_COMPILERS=ON`.
- Upgraded `contrib.lua` to Lua version 5.5.0 (#26033)

4.0.1 - 01/17/25
----------------
Expand Down
8 changes: 3 additions & 5 deletions tools/ports/contrib/lua.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

import os

TAG = '5.4.7'
HASH = '98c5c8978dfdf867e37e9eb3b3ec83dee92d199243b5119505da83895e33f10d43c841be6a7d3b106daba8a0b2bd25fe099ebff8f87831dcc55c79c78b97d8b8'
TAG = '5.5.0'
HASH = '3253d2cdc929da6438095a30d66ef16a1abdbb0ada8fee238705b3b38492f14be9553640fdca6b25661e01155ba5582032e0a2ef064e4c283e85efc0a128cabe'

# contrib port information (required)
URL = 'https://www.lua.org/'
Expand Down Expand Up @@ -36,9 +36,7 @@ def create(final):
ldblib.c liolib.c lmathlib.c loadlib.c loslib.c lstrlib.c ltablib.c lutf8lib.c linit.c
'''.split()

flags = ['-DLUA_COMPAT_5_3']
Copy link
Collaborator

@sbc100 sbc100 Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@ypujante ypujante Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag doesn't exist anymore so it's useless to leave it

Copy link
Collaborator

@sbc100 sbc100 Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why it was being used previously?

Copy link
Contributor Author

@ypujante ypujante Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that when they upgraded to 5.4 this flag was being used to still enable what was being deprecated/removed from 5.3. With the release of 5.5 it's truly removed so there's no way to reenable it, so the flag is gone. As I pointed out there is no such equivalent flag for 5.4


ports.build_port(source_path, final, port_name, srcs=srcs, flags=flags)
ports.build_port(source_path, final, port_name, srcs=srcs)

return [shared.cache.get_lib(lib_name, create, what='port')]

Expand Down