Skip to content

[tsgen] Preserve user ENVIRONMENT during TS generation. #26049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendandahl merged 1 commit into from
Jan 7, 2026
Merged

[tsgen] Preserve user ENVIRONMENT during TS generation. #26049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3590,6 +3590,7 @@ def test_embind_tsgen_end_to_end(self, opts, tsc_opts):
'3': [['-sWASM=0'], 'embind_tsgen_ignore_3.d.ts'],
'4': [['-fsanitize=undefined', '-gsource-map'], 'embind_tsgen_ignore_3.d.ts'],
'5': [['-sASYNCIFY'], 'embind_tsgen_ignore_3.d.ts'],
'6': [['-sENVIRONMENT=worker', '-lworkerfs.js'], 'embind_tsgen.d.ts'],
})
def test_embind_tsgen_ignore(self, extra_args, expected_ts_file):
create_file('fail.js', 'assert(false);')
Expand Down
3 changes: 2 additions & 1 deletion tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2011,7 +2011,8 @@ def run_embind_gen(options, wasm_target, js_syms, extra_settings):
settings.PRE_JS_FILES = []
settings.POST_JS_FILES = []
# Force node since that is where the tool runs.
settings.ENVIRONMENT = ['node']
if 'node' not in settings.ENVIRONMENT:
settings.ENVIRONMENT.append('node')
settings.MINIMAL_RUNTIME = 0
# Required function to trigger TS generation.
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$callRuntimeCallbacks', '$addRunDependency', '$removeRunDependency']
Expand Down