Fix --no-entry being ignored when -sASSERTIONS is enabled #26055
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tools/link.py to respect EXPECT_MAIN when adding main to EXPORT_IF_DEFINED in assertion builds. This prevents main from being force-exported when the user explicitly requests no entry point. Fixes emscripten-core#26047
sbc100
approved these changes
Jan 9, 2026
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_O0.json: 20629 => 20629 [+0 bytes / +0.00%] Average change: +0.00% (+0.00% - +0.00%) ```
Collaborator
|
Looks like a couple of valid test failures... maybe hard to resolve them? |
correctly distinguishes between 'user explicitly wants no entry' and 'user might have forgotten to export main'.
sbc100
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tools/link.py to respect EXPECT_MAIN when adding main to EXPORT_IF_DEFINED in assertion builds. This prevents main from being force-exported when the user explicitly requests no entry point.
Fixes #26047