[JSPI] Remove instrumentFunction. NFC #26170
Merged
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Jan 27, 2026
sbc100
force-pushed
the
instrumentFunction
branch
from
7c49a5c to
0bae8c9
Compare
I noticed that this was not doing anything in JSPI mode.
sbc100
force-pushed
the
instrumentFunction
branch
from
0bae8c9 to
75464ec
Compare
kripken
reviewed
Jan 27, 2026
| ret[x] = wrapper; | ||
|
|
||
| } else { | ||
| #endif |
Member
There was a problem hiding this comment.
Does this not match if ASYNCIFY == 2? (edit: from line 167) (if so, then my comment from above remains - can this not be reached with values 0 or 1?)
Please add a comment saying what it does match, if I'm reading this wrong.
Member
There was a problem hiding this comment.
Or is my confusion about JSPI - what is the value of ASYNCIFY when JSPI is enabled?
Collaborator
Author
There was a problem hiding this comment.
JSPI means ASYNCIFY == 2 yes, they are the same thing.
kripken
approved these changes
Jan 27, 2026
| ret[x] = wrapper; | ||
|
|
||
| } else { | ||
| #endif |
Collaborator
Author
|
@brendandahl WDYT? |
brendandahl
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this was not doing anything in JSPI mode.