Fix -sMODULARIZE + html output. NFC #26173
Merged
+134
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked with MINIMAL_RUNTIME but would error out otherwise. This removes the need to the custom shell_that_launches_modularize.html we used in test browser_test.py. Fixes: emscripten-core#7950
sbc100
force-pushed
the
remove_modularize_error
branch
from
cd26eea to
4eebe4c
Compare
kripken
reviewed
Jan 27, 2026
| statusElement.innerHTML = text; | ||
| }; | ||
|
|
||
| #if MODULARIZE && !EXPORT_ES6 |
Member
There was a problem hiding this comment.
It looks like this is the first time we use the preprocessor in these files - there is maybe some risk users were using the file directly? I thought we even had tests that just use the HTML, but maybe I'm wrong?
Collaborator
Author
There was a problem hiding this comment.
They already have {{{ SCRIPT }}} here in all of these files, so they already all need processing.
kripken
approved these changes
Jan 27, 2026
| statusElement.innerHTML = text; | ||
| }; | ||
|
|
||
| #if MODULARIZE && !EXPORT_ES6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked with MINIMAL_RUNTIME but would error out otherwise.
This removes the need to the custom shell_that_launches_modularize.html we used in test browser_test.py.
Fixes: #7950