Skip to content

Fix source maps issues on windows; followup to #9882 #9925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Fix source maps issues on windows; followup to #9882 #9925

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78b2a8
Fix source maps issues on windows; followup to #9882
kripken Nov 29, 2019
afb3a10
revert regexes
kripken Nov 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/wasm-sourcemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def resolve(self, name):
if name in self.cache:
return self.cache[name]

result = name.replace('\\', '/').replace('//', '/')
for p in self.prefixes:
if name.startswith(p['prefix']):
if p['replacement'] is None:
Expand Down Expand Up @@ -270,6 +269,8 @@ def build_sourcemap(entries, code_section_offset, prefixes, collect_sources, bas
column = 1
address = entry['address'] + code_section_offset
file_name = entry['file']
# normalize between OSes
file_name = file_name.replace('\\', '/').replace('//', '/')
# if prefixes were provided, we use that; otherwise, we emit a relative
# path
if prefixes.provided():
Expand Down