-
Notifications
You must be signed in to change notification settings - Fork 760
Firefox support #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juj
wants to merge
39
commits into
main
Choose a base branch
from
firefox_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Firefox support #1606
Changes from 33 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
a8ac2cd
Add emsdk manifest entries for downloading Firefox.
juj 45112a3
Add support for installing Firefox on Linux
juj e64ba76
Add git branch markers
juj 8c0b743
Fix daily path
juj 4dd06a2
Autoinstall mozdownload
juj 6c58b2a
Add firefox 90.0
juj b48c933
Firefox 120
juj bd4cab3
Add Firefox 130
juj c5fbe8a
Add Firefox 125
juj 9ce1de9
125.0.1
juj 801073c
Add 122.0
juj 8ebe2eb
MacOS support
juj fd0aeb7
Add Firefox 123.0
juj 6003b3e
Fix is_firefox_installed on MacOS.
juj 65521c7
Add Firefox 100.0 and 110.0
juj 8a3b828
Add Firefox esr
juj 3377c89
Only attempt mozdownload reinstall if mozdownload import does not work.
juj 6516449
flake
juj bf39cf7
Fix MacOS for Firefox Nightly
juj ec0cf2b
Fix attach
juj 2687a33
fix 2
juj 7d9ac48
daily -> nightly (they are the same)
juj faac848
Add 140.3.1esr
juj a273a9b
nightly->daily
juj ab1547e
Fix typo
juj 9c1bdf5
Fix mac cfg
juj d78bb89
Fix save version
juj 1cc37cd
no f
juj ac87ea1
Add Firefox beta
juj fe8c557
ImportError
juj 214c810
Cleanup
juj 538cdab
Fix typo
juj ab8744a
Rename config field for browsers
juj cdb956d
Set Firefox 79 as the minimum supported version
juj 199f4c9
Revert "Set Firefox 79 as the minimum supported version"
juj 4e59bf9
Remove the redundant temp directory after move
juj 886e67f
Add Linux ARM64 download support
juj bf8924d
Remove Firefox 65
juj 4d5276b
Hide old Firefox versions from install list by default
juj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,3 +33,4 @@ __pycache__ | |
/mingw | ||
/spidermonkey | ||
/binaryen | ||
/firefox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we modify the extraction process to strip the
Contents/MacOS
prefix, and avoid adding this newmac_activated_cfg
andmac_activated_env
concepts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are files in the other directories, e.g.
Contents/Resources/
. I could maybe remove theContents/
part, but that would be very non-Apple'esque, and any Apple native devs reading the code would likely read it to be a silly hack.