-
Notifications
You must be signed in to change notification settings - Fork 11
Replace deprecated appdirs with platformdirs, fix config path lookup with non conda-based environments
#113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martinRenou
merged 13 commits into
emscripten-forge:main
from
agriyakhetarpal:fix/appdirs/platformdirs
Jan 27, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bf4dcf8
Replace `appdirs` with `platformdirs`
agriyakhetarpal 3e3fc97
Use `user_cache_dir` from `platformdirs`
agriyakhetarpal e66b5fa
Set `DEFAULT_CONFIG_PATH` to `user_config_dir`
agriyakhetarpal 8739917
Move `empack_config.yaml` to inside the project
agriyakhetarpal 615a34b
Revert "Move `empack_config.yaml` to inside the project"
agriyakhetarpal 7b318ff
Revert "Set `DEFAULT_CONFIG_PATH` to `user_config_dir`"
agriyakhetarpal 76e9405
Port `_do_i_own` helper method
agriyakhetarpal 273966b
Check for both conda/virtualenv style venvs
agriyakhetarpal 77f55e3
Fix type annotation
agriyakhetarpal 59cde9c
Add docstring
agriyakhetarpal f8b075f
Fix linter error
agriyakhetarpal ed052c8
Install appdirs for tests
agriyakhetarpal 3b3a32e
Fix linter error again
agriyakhetarpal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the CI says appdirs is still being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be addressed by emscripten-forge/pyjs-code-runner#15, marking for completeness :)