Skip to content

Replace deprecated appdirs with platformdirs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace deprecated appdirs with platformdirs #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43ef3bf
Replace `appdirs` with `platformdirs`
agriyakhetarpal Jan 24, 2025
2ba4e4f
Merge branch 'main' into fix/replace-appdirs-with-platformdirs
DerThorsten Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- pip
- pytest
- typer
- appdirs
- platformdirs
- empack >=3,<4
- microsoft::playwright
- emsdk
Expand Down
4 changes: 2 additions & 2 deletions pyjs_code_runner/get_cache_dir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import appdirs
import platformdirs

from pathlib import Path


def get_appdir():
path = Path(appdirs.user_data_dir("pyjs_code_runner", "ThorstenBeier"))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed ThorstenBeier here (and DerThorsten from conftest.py below), as these strings seemed like a remnant of testing code. The appauthor parameter should be picked up as whatever the default is automatically?

path = Path(platformdirs.user_data_dir("pyjs_code_runner"))
path.mkdir(parents=True, exist_ok=True)
return path

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ classifiers = [
"Programming Language :: Python :: 3.11",
]
dependencies = [
"appdirs",
"platformdirs",
"empack >=3.0.0",
"playwright",
"rich",
Expand Down
4 changes: 2 additions & 2 deletions test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest
import subprocess
from pathlib import Path
import appdirs
import platformdirs
import shutil
from typer.testing import CliRunner
import os
Expand All @@ -17,7 +17,7 @@

@pytest.fixture(scope="session")
def env_prefix():
env_root = Path(appdirs.user_data_dir("pytest_code_runner_tests", "DerThorsten"))
env_root = Path(platformdirs.user_data_dir("pytest_code_runner_tests"))
env_root.mkdir(exist_ok=True, parents=True)
env_prefix = Path(env_root) / "testenv"

Expand Down