Update python and node in emsdk package to match upstream emsdk #3464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anutosh491 As requested here compiler-research/xeus-cpp#400 (comment) this will fix your issue where emsdk was using an outdated version of node, which caused issues with your tests running.
The python change isn't strictly necessary but it will make Emscripten forges emsdk 3.1.73 recipe match the versions of node and python that the upstream emsdk uses for version 3.1.73 . i.e.
Assuming this PR is approved and goes in I will open up a minimal diff PR in xeus-cpp to take advantage of this change.