Update openblas with improved shared library building workflow#5132
Merged
ianthomas23 merged 2 commits intoemscripten-forge:mainfrom Mar 23, 2026
Merged
Update openblas with improved shared library building workflow#5132ianthomas23 merged 2 commits intoemscripten-forge:mainfrom
ianthomas23 merged 2 commits intoemscripten-forge:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template B: Checklist for updating a package
PR Formatting
Add [package-name]orUpdate [package-name] to [version]Package Details
Build Notes
Previously the
openblasrecipe built static llbraries using the source package makefiles but the shared libraries were built in a manual step. This PR improves the building workflow by using the source package makefiles for both, by specifying the C and Fortan compiler flags a bit more carefully and adding a one-line patch to one of the makefiles to avoid the shared library building trying to link with system libraries that are not required. The result of this is that the generated shared libraries are correctly versioned and the build config files include extra information that makes building downstream libraries easier to do.