Refactor wasm initialization #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
refactor_wasm_init
branch
3 times, most recently
from
eea85ee to
caf7638
Compare
martinRenou
force-pushed
the
refactor_wasm_init
branch
2 times, most recently
from
9bf395d to
2396fbd
Compare
martinRenou
commented
Nov 20, 2024
| import untarjs from "@emscripten-forge/untarjs"; | ||
| import { initUntarJS } from "@emscripten-forge/untarjs"; | ||
|
|
||
| const untarjs = await initUntarJS(); |
Collaborator
Author
There was a problem hiding this comment.
@AnastasiaSliusar note the change in the API here, this allows loading the WASM once.
martinRenou
force-pushed
the
refactor_wasm_init
branch
from
5a019bf to
c4c381d
Compare
Collaborator
Author
|
Thanks for the review @AnastasiaSliusar I've applied your suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will:
allow passing the wasmPath from outside (allow the webpack notationimport new URL('path-to.wasm', import.meta.url);)