This repository was archived by the owner on Oct 29, 2022. It is now read-only.
updated link #1
Merged
updated link #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! |
|
Hi @kripken, I am a maintainer on harfbuzz project and like to add emscripten support to harfbuzz upstream, can you have a look at harfbuzz/harfbuzz#743 which tries to add the support? Thanks. |
Member
|
@ebraminio sounds great! The PR seems to just edit the CMakeLists.txt file which is part of the build system, I'm not sure what to look at there? Or is it the comments and discussion you want me to look at? |
|
Yes, this part specially. Like projects hosted on this organization, I wish harfbuzz would have a recommended way to be built with, doing best for the users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.