[lpc/lpp eg] subscription and read request for scenario 4#189
Open
kirollosnct wants to merge 2 commits intodevfrom
Open
[lpc/lpp eg] subscription and read request for scenario 4#189kirollosnct wants to merge 2 commits intodevfrom
kirollosnct wants to merge 2 commits intodevfrom
Conversation
…onnection LPC/LPP EnergyGuard Prescenario and Initial scenario communication for scenario 4 to subscribe on ElectricalConnection feature and trigger a read request for electricalConnectionCharacteristicListData.
Needed for scenario 4 as the device type of the remote determines the type of the characteristic.
Member
|
Shouldn't we also check if scenario 4 is even announced as part of the usecase using |
Contributor
|
We should look into #198 and how that influences this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing pre-scenario and initial scenario communication for LPC/LPP EnergyGuard scenario 4, which requires to subscribe on ElectricalConnection feature and trigger a read request for electricalConnectionCharacteristicListData.