Skip to content

Change semantic of OR of two permission classes #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Change semantic of OR of two permission classes #6605

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7018784
Change semantic of OR of two permission classes
MarkYu98 Apr 24, 2019
f34bf9a
Update permissions.py
lovelydinosaur Sep 3, 2021
6fd656b
Update permissions.py
lovelydinosaur Jul 1, 2022
0ceb84b
Update permissions.py
lovelydinosaur Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rest_framework/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ def has_permission(self, request, view):

def has_object_permission(self, request, view, obj):
return (
self.op1.has_object_permission(request, view, obj) or
self.op2.has_object_permission(request, view, obj)
(self.op1.has_permission(request, view) and self.op1.has_object_permission(request, view, obj))
or
(self.op2.has_permission(request, view) and self.op2.has_object_permission(request, view, obj))
)


Expand Down