replace partition with split in BasicAuthentication #8790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Dec 3, 2022
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
can you please add tests as well?
Collaborator
|
should we update docs in related section for this change? can you please check? |
Contributor
Author
|
I just checked API Clients, Authentication, and Testing sections, and no updates are needed. |
auvipy
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, I replaced the partition method with split to increase code readability. Moreover now if the user provides credentials data without ':' AuthenticationFailed exception will be raised (to follow the basic authentication schema). Previously if the password was an empty string user could authenticate by passing credentials without a colon and password.