Skip to content

Add official support for Django 5.1 #9514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 7, 2024
Merged

Add official support for Django 5.1 #9514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
940f566
Add official support for Django 5.1
browniebroke Aug 29, 2024
bf0039d
Add tests to cover compat with Django's 5.1 LoginRequiredMiddleware
browniebroke Aug 30, 2024
48616f6
First pass to create DRF's LoginRequiredMiddleware
browniebroke Aug 30, 2024
6b55ccc
Attempt to fix the tests
browniebroke Aug 30, 2024
d295dfe
Revert custom middleware implementation
browniebroke Aug 30, 2024
dee68ec
Disable LoginRequiredMiddleware on DRF views
browniebroke Aug 30, 2024
7f9caf5
Document how to integrate DRF with LoginRequiredMiddleware
browniebroke Aug 30, 2024
63ce5c9
Move login required tests under a separate test case
browniebroke Aug 30, 2024
f7e8556
Revert redundant change
browniebroke Aug 30, 2024
2458547
Disable LoginRequiredMiddleware on ViewSets
browniebroke Aug 30, 2024
801304f
Add some integrations tests to cover various view types
browniebroke Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Some reasons you might want to use REST framework:
# Requirements

* Python 3.8+
* Django 5.0, 4.2
* Django 4.2, 5.0, 5.1

We **highly recommend** and only officially support the latest patch release of
each Python and Django series.
Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ continued development by **[signing up for a paid plan][funding]**.

REST framework requires the following:

* Django (4.2, 5.0)
* Django (4.2, 5.0, 5.1)
* Python (3.8, 3.9, 3.10, 3.11, 3.12)

We **highly recommend** and only officially support the latest patch release of
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def get_version(package):
'Framework :: Django',
'Framework :: Django :: 4.2',
'Framework :: Django :: 5.0',
'Framework :: Django :: 5.1',
'Intended Audience :: Developers',
'License :: OSI Approved :: BSD License',
'Operating System :: OS Independent',
Expand Down
13 changes: 4 additions & 9 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[tox]
envlist =
{py38,py39}-{django42}
{py310}-{django42,django50,djangomain}
{py311}-{django42,django50,djangomain}
{py312}-{django42,django50,djangomain}
{py310}-{django42,django50,django51,djangomain}
{py311}-{django42,django50,django51,djangomain}
{py312}-{django42,django50,django51,djangomain}
base
dist
docs
Expand All @@ -17,6 +17,7 @@ setenv =
deps =
django42: Django>=4.2,<5.0
django50: Django>=5.0,<5.1
django51: Django>=5.1,<5.2
djangomain: https://github.com/django/django/archive/main.tar.gz
-rrequirements/requirements-testing.txt
-rrequirements/requirements-optionals.txt
Expand All @@ -42,12 +43,6 @@ deps =
-rrequirements/requirements-testing.txt
-rrequirements/requirements-documentation.txt

[testenv:py38-djangomain]
ignore_outcome = true

[testenv:py39-djangomain]
ignore_outcome = true
Comment on lines -45 to -49
Copy link
Collaborator Author

@browniebroke browniebroke Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't test Django main against 3.8 or 3.9 so this is unused

Copy link
Collaborator

@auvipy auvipy Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right


[testenv:py310-djangomain]
ignore_outcome = true

Expand Down