Raise NotAcceptable if suffix or query format is not acceptable #9593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Nov 19, 2024
Contributor
|
I believe the reason for raising a 404 as opposed to a 406 was because that part of the code will only be triggered if URL path formatting is specified, at which point they would be requesting a non-existent endpoint as opposed to making a request with an invalid |
ulgens
reviewed
Nov 25, 2024
Contributor
ulgens
left a comment
ulgens
left a comment
There was a problem hiding this comment.
Not sure why it got closed but this looks like a nice catch and fix.
Contributor
|
I think @kevin-brown made the correct call here. (The current behaviour is intentional) Thanks to @JourneyBean for the suggestion, tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9591
Modified the error handling in
negotiation.pyto raiseexceptions.NotAcceptablewhen a renderer is not found.