Skip to content

Refactor token generation to use the secrets module #9760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2025
+41 −3
Merged

Refactor token generation to use the secrets module #9760

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c072a1f
Refactor token generation to use secrets module
mahdirahimi1999 Aug 9, 2025
8d08427
test: Add focused tests for Token.generate_key() method
mahdirahimi1999 Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rest_framework/authtoken/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import binascii
import os
import secrets

from django.conf import settings
from django.db import models
Expand Down Expand Up @@ -34,7 +33,7 @@ def save(self, *args, **kwargs):

@classmethod
def generate_key(cls):
return binascii.hexlify(os.urandom(20)).decode()
return secrets.token_hex(20)

def __str__(self):
return self.key
Expand Down
Loading