-
Notifications
You must be signed in to change notification settings - Fork 125
Ensure that all async generators are explicitly closed #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agronholm
wants to merge
17
commits into
encode:master
Choose a base branch
from
agronholm:asyncgenerators
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d4651f3
Ensure that all async generators are explicitly closed
agronholm 838252c
Fixed linting/formatting
agronholm c3688d0
Updated mypy
agronholm b5abb00
Use mypy 0.14.1 for py3.8 compat
agronholm 2ee74ed
Fixed mypy errors
agronholm 9d03a64
Ran unasync and fixed emerging problems
agronholm 239ba57
Fixed new mypy errors
agronholm c52711d
Fixed issue on Python 3.8
agronholm ca3d6d0
Dropped Python 3.8 support and added Python 3.13 to CI matrix
agronholm 7db7d9b
Fixed coverage problems
agronholm d090e35
Added Python 3.14 to test matrix and updated to latest setup-python
agronholm 55eaf40
Removed Python 3.14 from the test matrix
agronholm 04adadc
Covered the rest of cases where "async for" is used
agronholm bcf7e9e
Ran unasync again
agronholm 2e528d3
Replaced AsyncExitStack with safe_async_iterate()
agronholm 2f242e7
Replaced remaining AsyncExitStack uses
agronholm 01cdac7
Restored newer mypy
agronholm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe un-downgrade mypy, since Python 3.8 support was dropped.