Keep original host on IDNA decode errors #3710
Open
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Emoji domains (e.g.,
https://xn--i-7iq.ws/,https://xn--ls8h.la/) are not allowed by IDNA2008 but are supported by some TLDs, have valid TLS certificates, and work in browsers, curl, and Python'srequestslibrary.Previously, httpx would raise an
IDNAErrorwhen attempting to decode these Punycode domains, preventing legitimate requests.This PR modifies the
hostproperty to gracefully handle IDNA decode errors by catchingidna.IDNAErrorand keeping the originalxn--encoded form. This allows httpx to work with these real-world emoji domains.Checklist