Merge kabufuda #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CMakeLists.txt
Remove unrelated classes from Card.{cpp,hpp}
IconAddress makes no sense, points to the start of the banner, with the icon directly following,
Amends broken or missing doxygen parameters. While we're at it, we can expand the documentation a little bit to be somewhat more explanatory about the functions.
Ensures all inclusions are made where necessary.
Same behavior, but with stronger typing. We can also eliminate usages of magic values in some places.
Previously this was zeroing out the maker array, which it shouldn't be doing.
This reverts commit 698e37d.
Anonymous structs have a limitation on GCC when involving non-trivial default constructors, as it's a compiler extension and not actually standard C++ to use anonymous structs. We can give the struct a concrete name, which fixes this issue.
Same behavior, but ensures input absolutely satisfies the total amount of data that needs to be copied.
Makes conversions explicit in order to prevent error-prone implicit conversions.
Avoids a sign conversion
This doesn't modify instance state, so it can be turned into a const member function.
These don't modify member state, so they can be made const .
Maintains parity with hecl's version of the macro, etc.
Antidote
force-pushed
the
merge-kabufuda
branch
from
ee21619 to
1cc3040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First phase of merging kabufuda into aurora, this might be a bit messy so I'm doing this in a separate branch for the time being, I'm creating this PR for input as I go through the process of cleaning up and merging the two APIs more seamlessly.