Skip to content

Add offset to Section #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add offset to Section #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbb293
Add offset to Section
ethteck Aug 21, 2025
96e45c7
Update tests
ethteck Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions objdiff-core/src/obj/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ pub struct Section {
pub id: String,
pub name: String,
pub address: u64,
pub offset: Option<u64>,
pub size: u64,
pub kind: SectionKind,
pub data: SectionData,
Expand Down Expand Up @@ -414,6 +415,7 @@ static DUMMY_SECTION: Section = Section {
id: String::new(),
name: String::new(),
address: 0,
offset: None,
size: 0,
kind: SectionKind::Unknown,
data: SectionData(Vec::new()),
Expand Down
1 change: 1 addition & 0 deletions objdiff-core/src/obj/read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ fn map_sections(
id,
name: name.to_string(),
address: section.address(),
offset: section.file_range().map(|(start, _)| start),
size: section.size(),
kind,
data: SectionData(data),
Expand Down
4 changes: 4 additions & 0 deletions objdiff-core/src/obj/snapshots/objdiff_core__obj__read__test__combine_sections.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ expression: "(sections, symbols)"
id: ".text-0",
name: ".text",
address: 0,
offset: None,
size: 8,
kind: Code,
data: SectionData(
Expand Down Expand Up @@ -48,6 +49,7 @@ expression: "(sections, symbols)"
id: ".data-combined",
name: ".data",
address: 0,
offset: None,
size: 12,
kind: Data,
data: SectionData(
Expand Down Expand Up @@ -83,6 +85,7 @@ expression: "(sections, symbols)"
id: ".data-1",
name: ".data",
address: 0,
offset: None,
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -98,6 +101,7 @@ expression: "(sections, symbols)"
id: ".data-2",
name: ".data",
address: 0,
offset: None,
size: 0,
kind: Unknown,
data: SectionData(
Expand Down
21 changes: 21 additions & 0 deletions objdiff-core/tests/snapshots/arch_arm__read_arm.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,9 @@ Object {
id: ".text-0",
name: ".text",
address: 0,
offset: Some(
52,
),
size: 556,
kind: Code,
data: SectionData(
Expand Down Expand Up @@ -1715,6 +1718,9 @@ Object {
id: ".rela.text-0",
name: ".rela.text",
address: 0,
offset: Some(
3980,
),
size: 276,
kind: Unknown,
data: SectionData(
Expand All @@ -1732,6 +1738,9 @@ Object {
id: ".data-0",
name: ".data",
address: 0,
offset: Some(
608,
),
size: 76,
kind: Data,
data: SectionData(
Expand Down Expand Up @@ -1886,6 +1895,9 @@ Object {
id: ".rela.data-0",
name: ".rela.data",
address: 0,
offset: Some(
4256,
),
size: 204,
kind: Unknown,
data: SectionData(
Expand All @@ -1903,6 +1915,9 @@ Object {
id: ".symtab-0",
name: ".symtab",
address: 0,
offset: Some(
684,
),
size: 1680,
kind: Unknown,
data: SectionData(
Expand All @@ -1920,6 +1935,9 @@ Object {
id: ".strtab-0",
name: ".strtab",
address: 0,
offset: Some(
2364,
),
size: 1615,
kind: Unknown,
data: SectionData(
Expand All @@ -1937,6 +1955,9 @@ Object {
id: ".shstrtab-0",
name: ".shstrtab",
address: 0,
offset: Some(
4460,
),
size: 49,
kind: Unknown,
data: SectionData(
Expand Down
57 changes: 57 additions & 0 deletions objdiff-core/tests/snapshots/arch_arm__read_thumb.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3443,6 +3443,9 @@ Object {
id: ".symtab-0",
name: ".symtab",
address: 0,
offset: Some(
64,
),
size: 4240,
kind: Unknown,
data: SectionData(
Expand All @@ -3458,6 +3461,9 @@ Object {
id: ".strtab-0",
name: ".strtab",
address: 0,
offset: Some(
4304,
),
size: 4913,
kind: Unknown,
data: SectionData(
Expand All @@ -3473,6 +3479,9 @@ Object {
id: ".shstrtab-0",
name: ".shstrtab",
address: 0,
offset: Some(
9232,
),
size: 243,
kind: Unknown,
data: SectionData(
Expand All @@ -3488,6 +3497,9 @@ Object {
id: ".comment-0",
name: ".comment",
address: 0,
offset: Some(
9488,
),
size: 36,
kind: Unknown,
data: SectionData(
Expand All @@ -3503,6 +3515,9 @@ Object {
id: ".debug_info-0",
name: ".debug_info",
address: 0,
offset: Some(
9536,
),
size: 13724,
kind: Unknown,
data: SectionData(
Expand All @@ -3518,6 +3533,9 @@ Object {
id: ".rel.debug_info-0",
name: ".rel.debug_info",
address: 0,
offset: Some(
23264,
),
size: 7680,
kind: Unknown,
data: SectionData(
Expand All @@ -3533,6 +3551,9 @@ Object {
id: ".debug_macinfo-0",
name: ".debug_macinfo",
address: 0,
offset: Some(
30944,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3548,6 +3569,9 @@ Object {
id: ".debug_loc-0",
name: ".debug_loc",
address: 0,
offset: Some(
30944,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3563,6 +3587,9 @@ Object {
id: " rel.debug_loc-0",
name: " rel.debug_loc",
address: 0,
offset: Some(
30944,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3578,6 +3605,9 @@ Object {
id: ".debug_line-0",
name: ".debug_line",
address: 0,
offset: Some(
30944,
),
size: 180,
kind: Unknown,
data: SectionData(
Expand All @@ -3593,6 +3623,9 @@ Object {
id: ".rel.debug_line-0",
name: ".rel.debug_line",
address: 0,
offset: Some(
31136,
),
size: 12,
kind: Unknown,
data: SectionData(
Expand All @@ -3608,6 +3641,9 @@ Object {
id: ".debug_line-1",
name: ".debug_line",
address: 0,
offset: Some(
31152,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3623,6 +3659,9 @@ Object {
id: ".rel.debug_line-1",
name: ".rel.debug_line",
address: 0,
offset: Some(
31152,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3638,6 +3677,9 @@ Object {
id: ".debug_pubnames-0",
name: ".debug_pubnames",
address: 0,
offset: Some(
31152,
),
size: 18,
kind: Unknown,
data: SectionData(
Expand All @@ -3653,6 +3695,9 @@ Object {
id: ".rel.debug_pubnames-0",
name: ".rel.debug_pubnames",
address: 0,
offset: Some(
31184,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3668,6 +3713,9 @@ Object {
id: ".debug_aranges-0",
name: ".debug_aranges",
address: 0,
offset: Some(
31184,
),
size: 0,
kind: Unknown,
data: SectionData(
Expand All @@ -3683,6 +3731,9 @@ Object {
id: ".debug_abbrev-0",
name: ".debug_abbrev",
address: 0,
offset: Some(
31184,
),
size: 211,
kind: Unknown,
data: SectionData(
Expand All @@ -3698,6 +3749,9 @@ Object {
id: ".text-0",
name: ".text",
address: 0,
offset: Some(
31408,
),
size: 244,
kind: Code,
data: SectionData(
Expand Down Expand Up @@ -3811,6 +3865,9 @@ Object {
id: ".rela.text-0",
name: ".rela.text",
address: 0,
offset: Some(
31664,
),
size: 108,
kind: Unknown,
data: SectionData(
Expand Down
Loading
Loading