-
Notifications
You must be signed in to change notification settings - Fork 41
Implement diffing individual data symbols #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
I reworked the whole-section-symbol diffing a bit. Now, it doesn't try to reuse the real section symbols from the object at all like it did before, since those might not necessarily exist, or might only exist for some sections. Instead it creates a fake section symbol for each section with a unique name, and it does this at the end after sections have been combined. This fixes the following issues with the previous implementation:
|
# Conflicts: # objdiff-cli/src/cmd/report.rs
Implements diffing the data of just a single symbol when you click on it. This is useful for things like vtables and stringBases:
Fixes #173