[MIPS] Fix symbols being filtered out from target side of diff if target object contains .NON_MATCHING markers
#250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the same name and a `.NON_MATCHING` suffix. - Target side: Show all the symbols except the `.NON_MATCHING` ones. - Base side: Ignore all the `.NON_MATCHING` symbols and also ignore the ones with the same name without the suffix
AngheloAlf
changed the title
.NON_MATCHING markers
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent splat/spimdisasm release it started to generate
.NON_MATCHINGmarkers for all the disassembled symbols by default (ethteck/splat#466). Since this is a splat/spimdisasm specific issue, only the MIPS architecture is affected.This new behavior is producing issues on projects that uses objdiff as a diffing tool or to generate a progress report.
Diffing: Any symbol with a
.NON_MATCHINGmarker on the target side of the diff is completely absent, making impossible to do any diffing.Reporting: Since there are no symbols on the target side then everything is considered matched by objdiff.
This PR addresses those issues by conditionally applying the
.NON_MATCHINGfiltering on each side of the view..NON_MATCHINGsuffix..NON_MATCHINGsymbols and also ignore the ones with the same name without the suffixI did a few tests and this approach seems to fix the issues listed above, even when the target object has a corresponding
.NON_MATCHINGmarker for every other symbol.I implemented this by adding a new enum
DiffSide, and pass eitherDiffSide::TargetorDiffSide::BasetoArchMipsso the arch itself can know what side of the diff it is working with, allowing it to conditionally filter the symbols.I implemented this only for
ArchMips, but it should be simple to implement it to other arches if necessary.