Implement automatic symbol pairing for MSVC generated static functions #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsons26
force-pushed
the
msvc_static_match
branch
from
e0945da to
420a6d7
Compare
tomsons26
changed the title
tomsons26
force-pushed
the
msvc_static_match
branch
from
420a6d7 to
27db297
Compare
tomsons26
changed the title
tomsons26
force-pushed
the
msvc_static_match
branch
from
27db297 to
5723f12
Compare
|
Looks good, thanks!
I think it's fine as-is! I don't think there's a scenario where we'd have symbol names that match the patterns and shouldn't have this behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids having to remap these functions whenever the source file changes as the number after E changes seemingly based on line numbers
Should
matches!(section_kind, SectionKind::Code | SectionKind::Data | SectionKind::Bss)be moved tois_symbol_compiler_generatedas techically _$E appears only in code sections while the existing @ is for data?