Support more string encodings and allow copying unescaped strings #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use encoding_rs instead of CStr for UTF-8.
|
Only problem I can see: how would one know to use UTF-16BE vs LE? |
Collaborator
Author
If you don't already know which of the two is used for the project you're working on, I guess you'd check both and ignore the one that's gibberish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286. Also adds support for UTF-16, Windows-1252, EUC-JP, and Big5 (there are also more encodings supported by encoding_rs that could be added to the list of desired). Regular strings will now be labeled either (ASCII) or (UTF-8) instead of nothing.