Conversation
Annoyingly trailing whitespace after a tag in a link is significant and shows up underlined like the rest of the link. Reformat the template slightly to avoid this.
This is a bit semantically dubious for a page titled "branches" but it is useful and there is no other place to show it.
manuq
approved these changes
Jul 7, 2025
| branch.build.artifact["expires_at"] | pretty_datetime_from_iso8601 | ||
| }}</time> | ||
| </a> | ||
| }}</time></a> |
Comment on lines
+72
to
+87
| {% if latest_release %} | ||
| <li> | ||
| <b><a href="../">Latest release: {{ latest_release.data.name }}</a></b> | ||
| <br/> | ||
| <span class="build"> | ||
| Built on | ||
| <time datetime="{{ latest_release.asset.updated_at }}">{{ | ||
| latest_release.asset.updated_at | pretty_datetime_from_iso8601 | ||
| }}</time> | ||
| from tag | ||
| <a href="{{ latest_release.data.html_url }}">{{ | ||
| latest_release.data.tag_name | ||
| }}</a> | ||
| </span> | ||
| </li> | ||
| {% endif %} |
Contributor
There was a problem hiding this comment.
I wondered if this had to be a conditional of the whole <li> element, or for each sentence. It looks like it's simpler this way so 👍
Member
Author
There was a problem hiding this comment.
I made it conditional around the whole element because there isn't the same variety of choices as for branches: either there is a release asset, or there isn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a minor formatting issue from #39.
Before:
After: