Style each list entry with a rounded background box#47
Merged
Conversation
manuq
approved these changes
Jul 15, 2025
Contributor
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Looks better! I left a suggestion about removing unneeded CSS rules for the border.
branches.css
Outdated
Comment on lines
68
to
70
Contributor
There was a problem hiding this comment.
Is a transparent 1 pixel border needed?
branches.css
Outdated
Comment on lines
68
to
66
Contributor
There was a problem hiding this comment.
I checked and this is not needed. You can remove rules border-style, border-width and border-color, leaving only border-radius for the round effect.
Member
Author
There was a problem hiding this comment.
I didn't know that. I've been cargo-culting my own 1px transparent border for like 15 years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wjt.github.io/github-pages-branches-test/branches/