Improve error reporting when workflow isn't found#49
Merged
Conversation
Member
Author
|
(The refactoring is prep for a later change.) |
manuq
reviewed
Aug 6, 2025
Contributor
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Both the factor out commit and the commit that adds the hint to the error message look good to me! The pre-commit is failing with An unexpected error has occurred: FileNotFoundError: /home/runner/.local/bin/uv which has nothing to do with the changes.
Comment on lines
-123
to
+130
| raise ValueError(f"Workflow '{self.workflow_name}' not found") | ||
| raise ConfigurationError( | ||
| f"Workflow '{self.workflow_name}' not found. " | ||
| "Has this project been built at least once?" | ||
| ) |
manuq
approved these changes
Aug 6, 2025
Member
Author
|
It does indeed have nothing to do with these changes; I'm investigating it now. |
Previously, unless you looked at the output of the script (and interpreted the Python backtrace), in the case where the wrong workflow name is given, it has never run, or doesn't exist, the only visible error was "Process completed with exit code 1." It is not possible to remove the "Process completed with exit code 1." message, but it is possible to show an error message as an annotation next to it. Do so, with a clearer message. Fixes #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, unless you looked at the output of the script (and interpreted the Python backtrace), in the case where the wrong workflow name is given, it has never run, or doesn't exist, the only visible error was "Process completed with exit code 1."
It is not possible to remove the "Process completed with exit code 1." message, but it is possible to show an error message as an annotation next to it. Do so, with a clearer message.
Fixes #48