Conversation
Previously, we used https://github.com/tox-dev/action-pre-commit-uv, which installs pre-commit with uv, then uses https://github.com/tox-dev/pre-commit-uv to redirect pre-commit's use of venv and pip to instead use uv. (This is not to be confused with the https://github.com/astral-sh/uv-pre-commit hook that we use in `.pre-commit-config.yaml`. It's pre-commit and uv all the way down.) Currently there is an issue in pre-commit-uv where it fails to invoke uv. We don't actually depend on the (alleged) (probably small) performance improvement from managing pre-commit and its environments with uv. Use https://github.com/pre-commit/action instead, which installs pre-commit with pip, with appropriate caching. This action is in maintenance-only mode but it still works fine and is very simple. Fixes #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we used https://github.com/tox-dev/action-pre-commit-uv, which installs pre-commit with uv, then uses
https://github.com/tox-dev/pre-commit-uv to redirect pre-commit's use of venv and pip to instead use uv. (This is not to be confused with the https://github.com/astral-sh/uv-pre-commit hook that we use in
.pre-commit-config.yaml. It's pre-commit and uv all the way down.)Currently there is an issue in pre-commit-uv where it fails to invoke uv. We don't actually depend on the (alleged) (probably small) performance improvement from managing pre-commit and its environments with uv.
Use https://github.com/pre-commit/action instead, which installs pre-commit with pip, with appropriate caching. This action is in maintenance-only mode but it still works fine and is very simple.
Fixes #51