Don't set status if existing status is the same#78
Merged
Conversation
Previously we would unconditionally set a new status for each commit each time the job runs. https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status says: > Note: there is a limit of 1000 statuses per sha and context within a > repository. Attempts to create more than 1000 statuses will result in > a validation error. We appear to be hitting this limit for a very long-lived PR in Threadbare. Check the combined status for the commit, which includes the latest status for each context. Update the status only if there is no existing status for our context, or if the existing status does not match. (For instance, the URL may have changed.) Resolves #77
Member
Author
|
I'll merge this without review because this is causing an error email for every update to any Threadbare branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would unconditionally set a new status for each commit each time the job runs.
https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status says:
We appear to be hitting this limit for a very long-lived PR in Threadbare.
Check the combined status for the commit, which includes the latest status for each context. Update the status only if there is no existing status for our context, or if the existing status does not match. (For instance, the URL may have changed.)
Resolves #77