Merged
Conversation
Thanks to PR "Add a second eosdev tree" [1]. EOS has OSTree branches: * eos: common usage * eosdev: for development However, there is no need to create eosdev's OSTree commit every time and the OSTree commit creation takes time. So, add the "enable_eosdev" option to decide create eosdev's OSTree commit, or not. It is disabled by default. [1]: #152 Part-of: #151
To reduce development CI time, only create eosdev's OSTree commit on main branch. It saves about 7~8 minutes on PR's CI check. Part-of: #177
Contributor
Author
|
It saves a lot of development's test time and helps following debug. So, I'm going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to PR "Add a second eosdev tree" 1. EOS has OSTree branches:
However, there is no need to create eosdev's OSTree commit every time and the OSTree commit creation takes time. So, add the "enable_eosdev" option to decide create eosdev's OSTree commit, or not. It is disabled by default.
Then, to reduce development CI time, only create eosdev's OSTree commit on main branch. It saves about 7~8 minutes on PR's CI check.
Part-of: #151