Conversation
The public's initial-script for prepare-image.sh executes commands, like shell. So, it does not recognize BuildStream's syntax "-", nor "- |". Drop the wrong syntax from the initial-script. Part-of: #211
The systemd-sysusers-override.bst always modifies wrong files which belong to the build environment, until teach it the target's root path. Part-of: #211
Contributor
Author
|
I have tested it and built image locally. So, I'm going to merge it. Hope the nightly image build work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop wrong syntax from initial-script
The public's initial-script for prepare-image.sh executes commands, like shell. So, it does not recognize BuildStream's syntax
-, nor- |. Drop the wrong syntax from the initial-script.Teach initial-script the path of root
The systemd-sysusers-override.bst always modifies wrong files which belong to the build environment, until teach it the target's root path.
Fixes: #211