-
Notifications
You must be signed in to change notification settings - Fork 17
feat(parse): spruce up this package to make it useful #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3244036
chore(transform-this-module): avoid obnoxious under-construction warning
michaelfig 2c6823d
feat(types): add `Error`
michaelfig 7b62f09
feat(parse): spruce up this package to make it useful
michaelfig 9fcb8f8
chore(types): fix `TemplateStringsArray.raw`
michaelfig 7744805
fix(parse): propagate tagged template literal parse errors
michaelfig d33740c
test(parse): test justin bigint literals
michaelfig 3fe1ab2
feat(parse): add bigint literals to justin
michaelfig 4a82fd2
test(parse): sanitise and use `parser-utils.js`
michaelfig 53019eb
feat(parse)!: `IParserTag` return defaults to `{ ast, holes }`
michaelfig 77855d5
feat(parse): permit number and bigint underscore separators
michaelfig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| export { default as bootPeg } from './boot-peg.js'; | ||
| export { default as bootPegAst } from './boot-pegast.js'; | ||
| export { default as makePeg } from './quasi-peg.js'; | ||
| export { default as makeJSON } from './quasi-json.js'; | ||
| export { default as makeJustin } from './quasi-justin.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,20 @@ | ||
| export { default as bootPeg } from './boot-peg.js'; | ||
| import { bootPeg, bootPegAst, makePeg, makeJSON, makeJustin } from './all.js'; | ||
|
|
||
| export { bootPeg }; | ||
|
|
||
| // The currently-supported parse tags. | ||
|
|
||
| /** | ||
| * Parser template tag that creates new parser template tags from PEGs. | ||
| */ | ||
| export const peg = bootPeg(makePeg, bootPegAst); | ||
|
|
||
| /** | ||
| * JSON parser template tag. | ||
| */ | ||
| export const json = makeJSON(peg); | ||
|
|
||
| /** | ||
| * Justin parser template tag. | ||
| */ | ||
| export const justin = makeJustin(peg.extends(json)); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok... I got this to work in the case of:
My first attempt was:
The diagnostic was pretty misleading:
quasiRest is not a function.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this error. Now it returns the diagnostic I was expecting:
and I added support for bigint literals, so now you should get: