Upgrade dependencies and rebuild#38
Open
danny-goldberg-rally wants to merge 5 commits intoendre-spotlab:masterfrom
Open
Upgrade dependencies and rebuild#38danny-goldberg-rally wants to merge 5 commits intoendre-spotlab:masterfrom
danny-goldberg-rally wants to merge 5 commits intoendre-spotlab:masterfrom
Conversation
|
|
||
| # rollup.js default build output | ||
| dist/ | ||
| # dist/ |
Author
There was a problem hiding this comment.
dist is important to be able to update since the action runs dist/index.js
| @@ -2,7 +2,7 @@ | |||
| "compilerOptions": { | |||
| /* Basic Options */ | |||
| // "incremental": true, /* Enable incremental compilation */ | |||
| "target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ | |||
| "target": "esNEXT", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ | |||
Author
There was a problem hiding this comment.
might as well go with latest to keep it current?
| @@ -1,16 +1,17 @@ | |||
| import { GitHub } from '@actions/github'; | |||
Author
There was a problem hiding this comment.
this was no longer accessible, but RestEndpointMethods from octokit seemed to work
| async get_pull_request(pr_number: number): Promise<Octokit.PullsGetResponse> { | ||
| const getPrResponse = await this.restClient.pulls.get({ | ||
| // TODO: make this strongly typed | ||
| async get_pull_request(pr_number: number): Promise<any> { |
Author
There was a problem hiding this comment.
I had trouble actually finding what the up-to-date type is for this, but it does work as any
| @@ -77,7 +79,7 @@ export class GitHubClientWrapper implements GitHubClient{ | |||
| async set_pull_request_status(pr_number: number, new_status: "error" | "failure" | "pending" | "success"): Promise<void> { | |||
| const pullRequestData = await this.get_pull_request(pr_number); | |||
|
|
|||
| const statusResponse = await this.restClient.repos.createStatus({ | |||
| const statusResponse = await this.restClient.repos.createCommitStatus({ | |||
Author
There was a problem hiding this comment.
https://openbase.com/js/@octokit/rest/versions, 18.0.0
octokit.repos.createStatus()has been renamed tooctokit.repos.createCommitStatus()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya! I wanted to play with this locally and check it out, but I couldn't actually compile it until I fiddled with it.
I ended up upgrading all the things.